-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legacy:: Add <ruby> tag to marshaling and unmarshaling #331
Conversation
Codecov Report
@@ Coverage Diff @@
## legacy #331 +/- ##
============================================
- Coverage 87.67% 87.64% -0.03%
- Complexity 8877 8888 +11
============================================
Files 829 833 +4
Lines 22053 22065 +12
============================================
+ Hits 19334 19339 +5
- Misses 2719 2726 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all looks good and pretty similar with original PR. just few thought and change requests
TR-4502
Description
Since Ruby tags are a standard HTML5 feature, they are natively supported by all major web browsers. This means that manually adding Ruby to the QTI XML markup should already works out of the box in the Test Runner. However there seems to be a blocker in our package publication (QTI marshalling of HTML5 ruby tags) that prevents publishing a test that contains item(s) with Ruby markup.
Aceptence criteria
Marshallers/unmarshallers for the following Ruby tags are added in QTI-SDK:
Development impact
Add tag description classes
Add new Marshaling
Add new UnMarshaling
Add test for cover new elements
Other PRs in context
JsonCompilation
QTI-SDK
Demo
TR-4502.mov