Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy:: Add <ruby> tag to marshaling and unmarshaling #331

Merged
merged 13 commits into from
Sep 30, 2022

Conversation

kilatib
Copy link
Contributor

@kilatib kilatib commented Sep 23, 2022

TR-4502

Description

Since Ruby tags are a standard HTML5 feature, they are natively supported by all major web browsers. This means that manually adding Ruby to the QTI XML markup should already works out of the box in the Test Runner. However there seems to be a blocker in our package publication (QTI marshalling of HTML5 ruby tags) that prevents publishing a test that contains item(s) with Ruby markup.

Aceptence criteria

Marshallers/unmarshallers for the following Ruby tags are added in QTI-SDK:



Development impact

Add tag description classes
Add new Marshaling
Add new UnMarshaling
Add test for cover new elements

Other PRs in context

JsonCompilation
QTI-SDK

Demo

TR-4502.mov

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Merging #331 (e6e726b) into legacy (b3ba786) will decrease coverage by 0.02%.
The diff coverage is 94.44%.

❗ Current head e6e726b differs from pull request most recent head f02ab7f. Consider uploading reports for the commit f02ab7f to get more accurate results

@@             Coverage Diff              @@
##             legacy     #331      +/-   ##
============================================
- Coverage     87.67%   87.64%   -0.03%     
- Complexity     8877     8888      +11     
============================================
  Files           829      833       +4     
  Lines         22053    22065      +12     
============================================
+ Hits          19334    19339       +5     
- Misses         2719     2726       +7     
Impacted Files Coverage Δ
...data/storage/xml/marshalling/ContentMarshaller.php 97.00% <83.33%> (-1.06%) ⬇️
qtism/data/content/xhtml/html5/Rb.php 100.00% <100.00%> (ø)
qtism/data/content/xhtml/html5/Rp.php 100.00% <100.00%> (ø)
qtism/data/content/xhtml/html5/Rt.php 100.00% <100.00%> (ø)
qtism/data/content/xhtml/html5/Ruby.php 100.00% <100.00%> (ø)
...data/storage/xml/marshalling/MarshallerFactory.php 98.51% <100.00%> (ø)
...storage/xml/marshalling/Qti22MarshallerFactory.php 100.00% <100.00%> (ø)
...ta/storage/xml/marshalling/RecursiveMarshaller.php 96.90% <100.00%> (+0.06%) ⬆️
...me/rendering/markup/xhtml/XhtmlRenderingEngine.php 100.00% <100.00%> (ø)
...a/storage/xml/marshalling/BlockquoteMarshaller.php 89.28% <0.00%> (-3.58%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@poyuki poyuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good and pretty similar with original PR. just few thought and change requests

@kilatib kilatib requested a review from poyuki September 30, 2022 11:25
@kilatib kilatib merged commit 0d7c8a3 into legacy Sep 30, 2022
@kilatib kilatib deleted the feature/TR-4502/add-ruby-tags_legacy branch September 30, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants