Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: use tokens from store" #140

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Revert "fix: use tokens from store" #140

merged 1 commit into from
Apr 21, 2022

Conversation

shpran
Copy link
Contributor

@shpran shpran commented Apr 21, 2022

Reverts #135

bziondik
bziondik approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@bziondik bziondik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shpran shpran force-pushed the revert-135-fix/oatsd-1783/get-tokens-from-store branch from 15227f2 to af299ec Compare April 21, 2022 07:39
@github-actions
Copy link

Version

Target Version 1.18.2
Last version 1.18.1

There are 0 BREAKING CHANGE, 0 feature, 1 fix

@github-actions
Copy link

Coverage Report

Totals Coverage
Statements: 90.56% ( 2666 / 2944 )
Methods: 94.18% ( 777 / 825 )

meefox
meefox approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@meefox meefox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as revert it is ok but this code could be refactored

jsconan
jsconan approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@jsconan jsconan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Review Checklist

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic

@shpran shpran merged commit 3caea57 into develop Apr 21, 2022
This was referenced Apr 21, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsconan jsconan jsconan approved these changes

@meefox meefox meefox approved these changes

@bziondik bziondik bziondik approved these changes

@tikhanovichA tikhanovichA Awaiting requested review from tikhanovichA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shpran @jsconan @meefox @bziondik