Fix/TR-3995/Max words restriction can be exceeded #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to account, also refactor the helper
Version
There are 0 BREAKING CHANGE, 0 feature, 3 fixes |
Coverage Report
|
This was referenced May 6, 2022
meefox
approved these changes
May 11, 2022
There was a problem hiding this comment.
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
- Changelog is updated according to changes (if applicable)
- Documentation is updated according to changes (if applicable)
shaveko
approved these changes
May 12, 2022
| * @param {Node} fragment | ||
| */ | ||
| const limitFragment = fragment => { | ||
| [].slice.call(fragment.childNodes).forEach(node => { |
There was a problem hiding this comment.
nitpick: may be we can rely on ES6 equivalent Array.from() here?
There was a problem hiding this comment.
Indeed, I was considering using it. But as there might be a need to backport it to an older version than needs IE support I preferred to stay safe.
|
QA verified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/4
Related to: https://oat-sa.atlassian.net/browse/TR-3995
The helper
util/strLimiteris aimed at limiting a text to a maximum number of units, either chars or words. Unfortunately, so far it was exclusively expecting plain text and it was producing wrong results with HTML.This pull request proposes to support either plain text or HTML text.
How to test:
Without the fix, the limit can be overflown.
With the fix, we cannot overflow the limit.