Breaking/tao 4814 atomic bundles #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/oat-sa/tao-core into breaking/TAO-4814_atomic-bundles
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| * - execute the start method of those controllers | ||
| * @param {String} url - the | ||
| */ | ||
| dispatchUrl : function dispatchUrl(url){ |
There was a problem hiding this comment.
Function dispatchUrl has 69 lines of code (exceeds 25 allowed). Consider refactoring.
| if(moduleRoutes.deps){ | ||
| dependencies = dependencies.concat(moduleRoutes.deps); | ||
| } | ||
| if(moduleRoutes.css){ |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| if(action.deps){ | ||
| dependencies = dependencies.concat(action.deps); | ||
| } | ||
| if(action.css){ |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit 8443356 and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
This was referenced Oct 16, 2018
This was referenced Oct 16, 2018
|
all good! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate TAO to the atomic bundles process
Requires
Feature/tao 4814 bundler task grunt-tao-bundle#1
use the new bundler library
use a unique configuration for the AMD build and test
views/build/config/requirejs.build.jsonupdate the router to load bundles (and test it by the way)
update the AMD loader tag to always load the vendor module
update the tao build config
Using the PR you should be able to run build the bundles for the tao extension :