Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/NEX-132_vendorization of item runner #2

Merged
merged 11 commits into from Jun 17, 2019
Merged

feature/NEX-132_vendorization of item runner #2

merged 11 commits into from Jun 17, 2019

Conversation

btamas
Copy link
Contributor

@btamas btamas commented Jun 12, 2019 •
edited

Vendorization of tao item runner.

Jira: https://oat-sa.atlassian.net/browse/NEX-132

Post task:

  • release to npm registry

@btamas btamas marked this pull request as ready for review June 12, 2019 12:23
@btamas btamas requested a review from krampstudio June 12, 2019 12:23
@btamas btamas changed the title bundler and testrunner feature/NEX-132_vendorization of item runner Jun 12, 2019
@oatymart oatymart mentioned this pull request Jun 13, 2019
Merged
ferenckiss89
ferenckiss89 approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@ferenckiss89 ferenckiss89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, all good.

oatymart
oatymart requested changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@oatymart oatymart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question about copyright years, and I just highlighted a couple of things the linter highlighted which we could take the time to improve.

src/assets/manager.js Outdated Show resolved Hide resolved
src/assets/manager.js Show resolved Hide resolved
src/assets/manager.js Outdated Show resolved Hide resolved
src/runner/api/itemRunner.js Outdated Show resolved Hide resolved
src/runner/api/itemRunner.js Outdated Show resolved Hide resolved
@btamas btamas requested a review from oatymart June 17, 2019 09:22
krampstudio
krampstudio suggested changes Jun 17, 2019
View reviewed changes
package.json Show resolved Hide resolved
src/runner/README.md Show resolved Hide resolved
@btamas btamas requested a review from krampstudio June 17, 2019 09:39
@krampstudio krampstudio merged commit 121e959 into develop Jun 17, 2019
@krampstudio krampstudio deleted the feature/NEX-132_vendorization-of-item-runner branch June 17, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krampstudio krampstudio krampstudio approved these changes

@ferenckiss89 ferenckiss89 ferenckiss89 approved these changes

@oatymart oatymart Awaiting requested review from oatymart

Assignees

@krampstudio krampstudio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@btamas @krampstudio @oatymart @ferenckiss89