Feature/TR-5854/Detect delivery concurrency #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
This was referenced Nov 24, 2023
jsconan
requested review from
hectoras,
erkobridee,
gabrielfs7,
shaveko and
shpran
jsconan
changed the title
Version
There are 0 BREAKING CHANGE, 4 features, 0 fix |
2 tasks
shaveko
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
The code looks nice
Thanks for the demo
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
erkobridee
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
all good 👍
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code respects code style rules
- New code respects best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
gabrielfs7
reviewed
Nov 30, 2023
| ); | ||
| testRunner.trigger('leave', { | ||
| code: states.testSession.suspended, | ||
| message: __( |
There was a problem hiding this comment.
- @jsconan Can you confirm how this string will be linked to PO files? I think Infosign will that there. Thanks! :)
There was a problem hiding this comment.
@gabrielfs7 the translation scanner will take care of it, from the consumer extension, as usual (say taoQtiTest)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://oat-sa.atlassian.net/browse/TR-5854
RFE: https://oat-sa.atlassian.net/browse/RFE-748
Summary
Add a mechanism for detecting concurrent delivery sessions.
Details
When the test runner initializes, a sequence number is stored in the browser's storage. Each time the duration is updated, the sequence number is read from the storage and compared with the value created at the beginning. If a discrepancy is discovered this means another test runner started meanwhile and updated the storage. A dialog message is presented to the user and the test runner is stopped.
How to test
npm cinpm testFor checking the feature, please refer to the companion PR: oat-sa/extension-tao-testqti#2420