Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Processed review from Justin Richer #45

Merged
merged 21 commits into from
May 1, 2024
Merged

Processed review from Justin Richer #45

merged 21 commits into from
May 1, 2024

Commits on Mar 24, 2024

  1. Processed review from Justin Richer

    @philippederyck
    philippederyck committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    a8db1b8 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Consistently used 'applications' instead of 'apps' 

    Resolve issue oauth-wg#42 by consistently using applications.
    @philippederyck
    philippederyck committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    55aac2e View commit details
    Browse the repository at this point in the history

  2. Updated sublist for proper rendering 

    This addresses issue oauth-wg#43
    @philippederyck
    philippederyck committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    23bbfc2 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Aaron Parecki <aaron@parecki.com>
    @philippederyck @aaronpk
    philippederyck and aaronpk committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    acdba5f View commit details
    Browse the repository at this point in the history

  4. Fixed a PR review comment

    @philippederyck
    philippederyck committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    f44e110 View commit details
    Browse the repository at this point in the history

  5. Added missing word 

    Added missing word as suggested in oauth-wg#46
    @philippederyck
    philippederyck committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    e355856 View commit details
    Browse the repository at this point in the history

  6. Fixed YAML issue to make the GH action gods happy

    @philippederyck
    philippederyck committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    9ff210a View commit details
    Browse the repository at this point in the history

  7. Temporarily removed invalid BCP references

    @philippederyck
    philippederyck committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    4312397 View commit details
    Browse the repository at this point in the history

  8. Fixed trailing whitespaces

    @philippederyck
    philippederyck committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    8743619 View commit details
    Browse the repository at this point in the history

  9. Addressed comments after discussing with Aaron 

    Addressing comments in oauth-wg#44
    @philippederyck
    philippederyck committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    023b300 View commit details
    Browse the repository at this point in the history

  10. Fixed trailing whitespace

    @philippederyck
    philippederyck committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    72c0e96 View commit details
    Browse the repository at this point in the history

  11. Fixed trailing whitespace

    @philippederyck
    philippederyck committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    b9c4a08 View commit details
    Browse the repository at this point in the history

  12. Removed refs to BCP

    @philippederyck
    philippederyck committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    105e037 View commit details
    Browse the repository at this point in the history

  13. Fixed author error in rendering

    @philippederyck
    philippederyck committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    09bcfd2 View commit details
    Browse the repository at this point in the history

  14. Debugging author error

    @philippederyck
    philippederyck committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    88c5f3e View commit details
    Browse the repository at this point in the history

  15. Addressing issue oauth-wg#44

    @philippederyck
    philippederyck committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    9289188 View commit details
    Browse the repository at this point in the history

  16. Addressing comments in oauth-wg#44

    @philippederyck
    philippederyck committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    61dbdf6 View commit details
    Browse the repository at this point in the history

  17. Debugging author issue

    @philippederyck
    philippederyck committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    f35fdd9 View commit details
    Browse the repository at this point in the history

  18. Debugging author issue

    @philippederyck
    philippederyck committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    82eb227 View commit details
    Browse the repository at this point in the history

  19. Debugging author issue

    @philippederyck
    philippederyck committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    032f209 View commit details
    Browse the repository at this point in the history

  20. Processing review comments 

    Finished oauth-wg#44
Working on oauth-wg#43
    @philippederyck
    philippederyck committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    5cbdc22 View commit details
    Browse the repository at this point in the history