Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to the main sd-jwt-python library branch #207

Merged
merged 1 commit into from Feb 13, 2024
Merged

Conversation

bc-pi
Copy link
Collaborator

@bc-pi bc-pi commented Feb 7, 2024

Switch back to the main branch of the sd-jwt-python library for example generation.

To fix #206 where sd_hash was missing from the Key Binding JWT in the example.

https://drafts.oauth.net/oauth-sd-jwt-vc/206_sd_hash/draft-ietf-oauth-sd-jwt-vc.html#section-4.2-2 has the PR preview of the fix

@bc-pi bc-pi linked an issue Feb 7, 2024 that may be closed by this pull request
Copy link
Collaborator

@awoie awoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with that specific python library but if you tested it, then it should be fine.

@bc-pi bc-pi requested a review from danielfett February 7, 2024 16:29
@danielfett danielfett merged commit 6df9cb0 into main Feb 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sd_hash to payload of Key Biniding JWT example
3 participants