Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of actor_token and actor_token_type #60

Closed
gffletch opened this issue Dec 18, 2023 · 4 comments
Closed

Use of actor_token and actor_token_type #60

gffletch opened this issue Dec 18, 2023 · 4 comments
Assignees
Labels

Comments

@gffletch
Copy link
Collaborator

Should we allow the use of actor_token and actor_token_type to be used as a means of client authentication for the Transaction Token Service? If not, should explicitly prohibit the use of these parameters in the profile of the Token Exchange spec.

@tulshi
Copy link
Collaborator

tulshi commented Dec 18, 2023

Since RFC8693 (Token Exchange) refers to the actor_token as "A security token that represents the identity of the acting party", we should not use it in the TraT request. I thought we wanted to have some way to convey the inbound token to the TraT service, and that's why we were using actor_token, but that is inconsistent with RFC8693. I think we should neither require nor disallow the use of actor_token because some implementations may want that for client auth, and some implementations may want to do something else (e.g. mTLS) for client auth.

@gffletch
Copy link
Collaborator Author

This is kind of what the spec says today. It's not required and up to the implementation. It is just referenced as an example. However, I'm fine removing the example and just being silent in the spec on the topic.

@gffletch
Copy link
Collaborator Author

Recommendation to update example and be silent on use of actor_token and actor_token_type. Add a section to Security Considerations to talk about client authentication and add some non-normative examples.

@gffletch gffletch self-assigned this Jan 12, 2024
@tulshi tulshi added the PR57 label Jan 12, 2024
@gffletch
Copy link
Collaborator Author

Removed the additional text regarding possible client authentication methods and just left it that the client MUST authenticate itself to the Transaction Token Service and that the specific client authentication method is out of scope for this specification.

gffletch added a commit to gffletch/transaction-tokens that referenced this issue Jan 24, 2024
@tulshi tulshi closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants