Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust domain/audience claim format URI or StringOrUri? #66

Closed
obfuscoder opened this issue Jan 30, 2024 · 0 comments · Fixed by #70
Closed

Trust domain/audience claim format URI or StringOrUri? #66

obfuscoder opened this issue Jan 30, 2024 · 0 comments · Fixed by #70

Comments

@obfuscoder
Copy link

In the Terminology section, the Trust Domain value is being defined and referenced in the aud claim as universal resource identifier. It should be spelled Universal Resource Identifier and a reference to RFC3986 should be added.

However, later in the document, the aud claim value is specified as defined in RFC7519. This RFC defines the aud claim as "StringOrURI". The different passages should be aligned.

Furthermore, the examples for the aud claim values should be aligned accordingly. In section Txn-Token Request the POST request example to the token service uses:

&audience=http%3A%2F%2Ftrust-domain.example

If an URI is used, I suggest to use 'https' instead of 'http'.

Later the JWT body example of the Txn-Token just uses a string:

"aud": "trust-domain.example",

obfuscoder pushed a commit to obfuscoder/oauth-transaction-tokens that referenced this issue Jan 30, 2024
obfuscoder pushed a commit to obfuscoder/oauth-transaction-tokens that referenced this issue Jan 30, 2024
@tulshi tulshi closed this as completed in #70 Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant