Update draft-ietf-oauth-transaction-tokens.md #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses text regarding the `aud` claim throughout the document. Issue oauth-wg#76
|
Although your changes sufficiently capture what is needed, what I liked about the previous draft is that it clearly identified that each Trust Domain MUST have a unique identifier, which is set as the |
|
Ok, let me see if there is a good place to add that. I wonder if it will be easier to merge PR #90 first and then let me fix this one as there may be conflicts? |
|
Makes sense to work on this after we merge #90
…On Fri, Apr 26, 2024 at 3:11 PM George Fletcher ***@***.***> wrote:
Ok, let me see if there is a good place to add that. I wonder if it will
be easier to merge PR #90
<#90> first and
then let me fix this one as there may be conflicts?
—
Reply to this email directly, view it on GitHub
<#89 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB55UG77Y2GZKFE7FSVPC7LY7LGIFAVCNFSM6AAAAABFO22ZLKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBQGE3TSNZWGI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
tulshi
reviewed
May 17, 2024
| @@ -339,7 +339,7 @@ JWT claims as well as defines new claims. These claims are described below: | |||
| : REQUIRED A unique transaction identifier as defined in Section 2.2 of {{RFC8417}}. When used in the transaction token, it identifies the entire call chain. | |||
|
|
|||
| `sub`: | |||
| : REQUIRED A unique identifier for the subject as defined by the `aud` trust domain. Unlike OpenID Connect, the `sub` claim is NOT associated with the `iss` claim. | |||
| : REQUIRED A unique identifier for the subject within the context of the `aud` trust boundary. Unlike OpenID Connect, the `sub` claim is NOT associated with the `iss` claim. | |||
There was a problem hiding this comment.
Did you intend for "trust boundary" to be something separaet from "trust domain"? I'd rather not invoke an additional concept if we can avoid it.
There was a problem hiding this comment.
Yes, I agree. Let me fix that.
changed trust boundary to trust domain to not introduce a new term/concept
tulshi
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses text regarding the
audclaim throughout the document. Issue #76