Skip to content

Commit

Permalink
Merge pull request #189 from RadOctocode/fix/remove-implicit-v
Browse files Browse the repository at this point in the history
removed v from version of oauth2-proxy deployment.yaml
  • Loading branch information
pierluigilenoci committed Apr 8, 2024
2 parents 7b37bf5 + e3d24dc commit 0330ef7
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions helm/oauth2-proxy/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: oauth2-proxy
version: 7.1.0
version: 7.2.0
apiVersion: v2
appVersion: 7.6.0
home: https://oauth2-proxy.github.io/oauth2-proxy/
Expand Down Expand Up @@ -34,8 +34,8 @@ maintainers:
kubeVersion: ">=1.9.0-0"
annotations:
artifacthub.io/changes: |
- kind: added
description: Make deploy.strategy configurable
- kind: changed
description: Remove the v from the oauth2-proxy deployment.yaml image
links:
- name: Github PR
url: https://github.com/oauth2-proxy/manifests/pull/188
url: https://github.com/oauth2-proxy/manifests/pull/189
2 changes: 1 addition & 1 deletion helm/oauth2-proxy/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ Compute the redis url if not set explicitly.
Returns the version
*/}}
{{- define "oauth2-proxy.version" -}}
{{ trimPrefix "v" (lower (.Values.image.tag | default (printf "v%s" .Chart.AppVersion))) }}
{{ .Values.image.tag | default (printf "v%s" .Chart.AppVersion) }}
{{- end -}}

{{/*
Expand Down
2 changes: 1 addition & 1 deletion helm/oauth2-proxy/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ spec:
{{- end }}
containers:
- name: {{ .Chart.Name }}
image: "{{ .Values.image.repository }}:v{{ include "oauth2-proxy.version" . }}"
image: "{{ .Values.image.repository }}:{{ include "oauth2-proxy.version" . }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
args:
{{- if .Values.alphaConfig.enabled }}
Expand Down

0 comments on commit 0330ef7

Please sign in to comment.