Update version of Redis chart dependency #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to work for me with a "architecture: replication" setup and three Redis pods. I have not tested cluster mode nor if the new major version has changes in actual API that might be considerd in the OAuth2-Proxy redis_store.go.
Closed
pierluigilenoci
requested changes
Sep 21, 2022
There was a problem hiding this comment.
This is not enough, you need to bump also the chart version.
Also the Chart.lock needs to be update.
Please refer to #79
Updated version in Chart.lock
|
@lathspell chart version bump is also needed. |
|
@lathspell could you please review again your PR? |
|
@lathspell could you please revisit again your PR? |
pierluigilenoci
previously approved these changes
Dec 27, 2022
|
@tlawrie @NickMeves @JoelSpeed @desaintmartin |
|
@lathspell could you please revisit again your PR? |
|
Closed in favor of #165 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to work for me with a "architecture: replication" setup and three Redis pods. I have not tested cluster mode nor if the new major version has changes in actual API that might be considerd in the OAuth2-Proxy redis_store.go.
Fixes #108