Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set strong securityContext by default #145

Merged
merged 8 commits into from
Jul 10, 2023

Conversation

jemag
Copy link
Contributor

@jemag jemag commented Apr 21, 2023

Fixes #142

I have been using this securityContext with 3 different oauth-proxy so far and have not encountered any issues. Would still appreciate someone other than me testing it as well.

Signed-off-by: Alexandre Desjardins <alexandre.bd@tutanota.com>
@jemag jemag marked this pull request as draft April 21, 2023 21:25
Signed-off-by: Alexandre Desjardins <alexandre.bd@tutanota.com>
Signed-off-by: Alexandre Desjardins <alexandre.bd@tutanota.com>
@jemag jemag marked this pull request as ready for review April 21, 2023 21:28
@pierluigilenoci
Copy link
Contributor

@jemag This is a breaking change that cannot be introduced this way.
We must avoid breaking previous installations.

@jemag
Copy link
Contributor Author

jemag commented Apr 23, 2023

@pierluigilenoci Do you have any suggestions on how you would like this change to be introduced?
Should I have incremented the Major version instead of Minor?

This should not be breaking previous installations and has not in my testing, but let me know if you think I missed something.

@pierluigilenoci
Copy link
Contributor

@jemag In reality, I don't feel very confident either to propose a possible solution.
I would prefer to have the opinion of the other maintainers as well.

@desaintmartin @tlawrie @NickMeves @JoelSpeed Would you be so kind as to give us an idea on how to deal with this?

@pierluigilenoci
Copy link
Contributor

@jemag I just noticed that you still need to document all the new parameters you added inside the README.md.
Can you do this, please?

@morganchristiansson
Copy link
Contributor

I applied these values and encountered no breaking changes. Thanks - seems like a great idea.

@pierluigilenoci pierluigilenoci merged commit c9ffb3b into oauth2-proxy:main Jul 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide good securityContext by default
3 participants