Skip to content

Commit

Permalink
Remove EmailDomain verification from GitLab provider
Browse files Browse the repository at this point in the history
This is handled globally
  • Loading branch information
Nick Meves committed Oct 9, 2020
1 parent 87d950b commit 38501f6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
1 change: 0 additions & 1 deletion pkg/validation/options.go
Expand Up @@ -273,7 +273,6 @@ func parseProviderInfo(o *options.Options, msgs []string) []string {
case *providers.GitLabProvider:
p.AllowUnverifiedEmail = o.InsecureOIDCAllowUnverifiedEmail
p.Groups = o.GitLabGroup
p.EmailDomains = o.EmailDomains

if o.GetOIDCVerifier() != nil {
p.Verifier = o.GetOIDCVerifier()
Expand Down
4 changes: 1 addition & 3 deletions providers/gitlab.go
Expand Up @@ -15,9 +15,7 @@ import (
type GitLabProvider struct {
*ProviderData

Groups []string
EmailDomains []string

Groups []string
Verifier *oidc.IDTokenVerifier
AllowUnverifiedEmail bool
}
Expand Down

0 comments on commit 38501f6

Please sign in to comment.