add nightly build and push #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuunit
force-pushed
the
feature/nigthly-builds
branch
from
f91cacd
to
d1d948c
Compare
kvanzuijlen
reviewed
Oct 31, 2023
@JoelSpeed let me know when you have created the new registry repo and I'll update it accordingly. |
JoelSpeed
reviewed
Nov 3, 2023
|
Are we creating a new repository or just using a nightly tag on the current repository? What do we want to create on Quay? |
I think I would prefer to push the nightly builds to a separate repository. Otherwise it will just clutter the main repository. In the case of a separate repository, I'll be renaming the necessary secrets to |
|
Ok, I'll set up a repo |
tuunit
force-pushed
the
feature/nigthly-builds
branch
from
3e61529
to
4b167ff
Compare
|
@JoelSpeed I updated the branch and the Makefile to point to the correct repository. |
tuunit
force-pushed
the
feature/nigthly-builds
branch
from
4b167ff
to
34476d9
Compare
JoelSpeed
reviewed
Nov 5, 2023
tuunit
force-pushed
the
feature/nigthly-builds
branch
from
34476d9
to
cd77a68
Compare
JoelSpeed
previously approved these changes
Nov 18, 2023
tuunit
force-pushed
the
feature/nigthly-builds
branch
from
cd77a68
to
26c2f8a
Compare
JoelSpeed
approved these changes
Nov 18, 2023
tuunit
added a commit
to tuunit/oauth2-proxy
that referenced
this pull request
Nov 20, 2023
* add nightly build and push * add date based nightly build tags * only keep single multiarch image build and push * add changelog * add images to internal docs static files * add docu for nightly builds * remove unnecessary spaces * update nightly repository
tuunit
added a commit
to tuunit/oauth2-proxy
that referenced
this pull request
Nov 20, 2023
* add nightly build and push * add date based nightly build tags * only keep single multiarch image build and push * add changelog * add images to internal docs static files * add docu for nightly builds * remove unnecessary spaces * update nightly repository
3 tasks
Now this is merged to master it might be a good idea to disable the nightly workflow from running in forks, since (a) I doubt you want forked repos trying to push to your I've suggested the obvious fix in #2330 |
tuunit
added a commit
to tuunit/oauth2-proxy
that referenced
this pull request
Dec 17, 2023
* add nightly build and push * add date based nightly build tags * only keep single multiarch image build and push * add changelog * add images to internal docs static files * add docu for nightly builds * remove unnecessary spaces * update nightly repository
tuunit
added a commit
to tuunit/oauth2-proxy
that referenced
this pull request
Dec 18, 2023
* add nightly build and push * add date based nightly build tags * only keep single multiarch image build and push * add changelog * add images to internal docs static files * add docu for nightly builds * remove unnecessary spaces * update nightly repository
JoelSpeed
added a commit
that referenced
this pull request
Dec 18, 2023
* Add GitHub groups (orgs/teams) support * align code of getTeams with getOrgs to support Github Enterprise Server instances with different domain * add documentation * add missing import after rebase * add nightly build and push (#2297) * add nightly build and push * add date based nightly build tags * only keep single multiarch image build and push * add changelog * add images to internal docs static files * add docu for nightly builds * remove unnecessary spaces * update nightly repository * Issue 978: Fix Custom cookie name breaks redis for session (#1949) * Issue 978: Fix Custom cookie name breaks redis for session (see #978) * Issue 978: Fix Custom cookie name breaks redis for session (see #978) * Update CHANGELOG.md * Issue 978: Fix Custom cookie name breaks redis for session * Issue 978: Fix Custom cookie name breaks redis for session * Issue 978: Fix Custom cookie name breaks redis for session * Issue 978: Fix Custom cookie name breaks redis for session * Issue 978: Fix Custom cookie name breaks redis for session * Issue 978: Fix Custom cookie name breaks redis for session * Update CHANGELOG.md --------- Co-authored-by: Nuno Borges <Nuno.Borges@ctw.bmwgroup.com> Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk> * Support http.AllowQuerySemicolons (#2248) * Support http.AllowQuerySemicolons * Docs * Make it clear we are overriding the handler * Update documentation for allow-query-semicolons * Fix changelog format * Fix formatting --------- Co-authored-by: MickMake <github@mickmake.com> * Add GitHub groups (orgs/teams) support * align code of getTeams with getOrgs to support Github Enterprise Server instances with different domain * add documentation * fix changelog & documentation * fix missing import --------- Co-authored-by: Tobias Mayer <github@tobiasm.de> Co-authored-by: Nuno Miguel Micaelo Borges <miguelborges99@gmail.com> Co-authored-by: Nuno Borges <Nuno.Borges@ctw.bmwgroup.com> Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk> Co-authored-by: Tim White <tim.white@su.org.au> Co-authored-by: MickMake <github@mickmake.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add nightly docker image build and publish workflow for the oauth2-proxy master branch. To always have a "bleeding edge" build of the latest merges for the community to test.
This PR requires the addition of the repository secrets for a service account with access to the quay.io repo:
REGISTRY_USERNAME_NIGHTLYREGISTYR_PASSWORD_NIGHTLYMotivation and Context
As the release cycle is rather slow some features might only be available on the master branch for weeks or month at a time. Therefore it would be great to have nightly builds of the master branch available.
How Has This Been Tested?
Build and publish workflow has been executed locally and on a forked repo.
Further notes
I took the liberty to update the doc images as part of this PR.
Checklist: