Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client-secret-file to main FlagSet #399

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

niraizik
Copy link
Contributor

Description

Fix #396

Motivation and Context

Missing client-secret-file flag in flag set fail options.Resolve
Application fail at startup

How Has This Been Tested?

App do not fail any more

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

Copy link
Member

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @niraizik, LGTM

@JoelSpeed JoelSpeed merged commit edd6ad6 into oauth2-proxy:master Feb 17, 2020
@niraizik niraizik deleted the fix_396_flag_not_exist branch February 17, 2020 14:37
@JoelSpeed JoelSpeed mentioned this pull request Apr 24, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to start with error flag "client-secret-file" does not exist
2 participants