Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement validateRedirectUri model function #482

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheNoim
Copy link

@TheNoim TheNoim commented Mar 25, 2018

Why should we not be able to verify our uris by ourself.
// TODO: Add to docs

@thomseddon
Copy link
Member

Hi, to get this merged we'd need some tests & docs please

@mjsalinger
Copy link
Contributor

@TheNoim Can you describe your use case for this? I'm not quite sure why it's necessary...

@TheNoim
Copy link
Author

TheNoim commented Aug 19, 2018

I can not remember my exact use case or in which project I wanted to use this but a basic use case would be one of this:

  • Custom uri support
  • wildcard support if wanted
  • own validation rules

@geekdada
Copy link

+1

redirect_uri doesn't have to be exactly equal to any of the redirectUris. Conditions listed below are acceptable on some occasions.

  • same origin and same pathname but different query
  • same origin but different pathname
  • same domain but different protocol
  • same top level domain

@geekdada
Copy link

Passing context to all methods also will do the trick.

There are quite a lot of issues depend on this feature:

#536 #336 #150

@thomseddon thomseddon force-pushed the master branch 2 times, most recently from 08f0399 to b84778b Compare May 24, 2020 14:16
@whlsxl
Copy link

whlsxl commented Jan 15, 2021

Any update for this pull request?

@whlsxl
Copy link

whlsxl commented Jan 15, 2021

#229

@NilsBaumgartner1994
Copy link

Push, we realy need wildcard redirect uris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants