fix: Bearer regular expression matching in authenticate handler #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation ( lib/handlers/authenticate-handler.ts#L145 ) of the pattern matching for the Bearer token matches only the string "Bearer" followed by one whitespace character followed by any number of non-whitespace characters. However, the loophole in the expression is that one can prefix the Authorization string with any string before the "Bearer" string and still get away with a successful match. This means that `fooBearer bar` or `foo Bearer bar` are valid headers according to the code. RFC 6750 | OAuth 2.0 Bearer Token Usage | Section 2.1 https://tools.ietf.org/html/rfc6750#section-2.1 specifies that the Authorization header start with the string "Bearer". This changeset modifies the code and the test case to make the above examples get thrown as `InvalidRequestError`s
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation ( lib/handlers/authenticate-handler.ts#L145 )
of the pattern matching for the Bearer token matches only the string
"Bearer" followed by one whitespace character followed by any number of
non-whitespace characters. However, the loophole in the expression is
that one can prefix the Authorization string with any string before the
"Bearer" string and still get away with a successful match.
This means that
fooBearer barorfoo Bearer barare valid headersaccording to the code.
RFC 6750 | OAuth 2.0 Bearer Token Usage | Section 2.1
https://tools.ietf.org/html/rfc6750#section-2.1
specifies that the Authorization header start with the string "Bearer".
This changeset modifies the code and the test case to make the above
examples get thrown as
InvalidRequestErrors