Skip to content

Commit

Permalink
Update pre-configured OIDC server to use OIDC flavor of Refresh Token…
Browse files Browse the repository at this point in the history
… grant type (#838)

* Modify pre-configured OIDC server to use OIDC Refresh Token grant type

* Add test coverage for OIDC refresh token grant type

* Use longer variable names
  • Loading branch information
burkel24 committed Oct 6, 2022
1 parent f1cc9c8 commit 7e69a15
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 2 deletions.
6 changes: 4 additions & 2 deletions oauthlib/openid/connect/core/endpoints/pre_configured.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,13 @@
from oauthlib.oauth2.rfc6749.grant_types import (
AuthorizationCodeGrant as OAuth2AuthorizationCodeGrant,
ClientCredentialsGrant, ImplicitGrant as OAuth2ImplicitGrant,
RefreshTokenGrant, ResourceOwnerPasswordCredentialsGrant,
ResourceOwnerPasswordCredentialsGrant,
)
from oauthlib.oauth2.rfc6749.tokens import BearerToken

from ..grant_types import AuthorizationCodeGrant, HybridGrant, ImplicitGrant
from ..grant_types import (
AuthorizationCodeGrant, HybridGrant, ImplicitGrant, RefreshTokenGrant
)
from ..grant_types.dispatchers import (
AuthorizationCodeGrantDispatcher, AuthorizationTokenGrantDispatcher,
ImplicitTokenGrantDispatcher,
Expand Down
32 changes: 32 additions & 0 deletions tests/openid/connect/core/endpoints/test_refresh_token.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
"""Ensure that the server correctly uses the OIDC flavor of
the Refresh token grant type when appropriate.
When the OpenID scope is provided, the refresh token response
should include a fresh ID token.
"""
import json
from unittest import mock

from oauthlib.openid import RequestValidator
from oauthlib.openid.connect.core.endpoints.pre_configured import Server

from tests.unittest import TestCase


class TestRefreshToken(TestCase):

def setUp(self):
self.validator = mock.MagicMock(spec=RequestValidator)
self.validator.get_id_token.return_value='id_token'

self.server = Server(self.validator)

def test_refresh_token_with_openid(self):
request_body = 'scope=openid+test_scope&grant_type=refresh_token&refresh_token=abc'
headers, body, status = self.server.create_token_response('', body=request_body)
self.assertIn('id_token', json.loads(body))

def test_refresh_token_no_openid(self):
request_body = 'scope=test_scope&grant_type=refresh_token&refresh_token=abc'
headers, body, status = self.server.create_token_response('', body=request_body)
self.assertNotIn('id_token', json.loads(body))

0 comments on commit 7e69a15

Please sign in to comment.