Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for custom signature methods to oauth1.Client #239

Merged
merged 2 commits into from
Apr 12, 2014
Merged

Add support for custom signature methods to oauth1.Client #239

merged 2 commits into from
Apr 12, 2014

Commits on Mar 25, 2014

  1. Enforcing a common interface for sign_*() methods... 

    In order to support adding custom signature methods, the current signature methods -- HMAC-SHA1, RSA-SHA1, and PLAINTEXT -- need to be implemented with a common interface. In a previous attempt, I tried changing those functions directly, but there are too many dependencies on their current signatures. By shimming them instead with these thin wrappers, I can provide the common interface I need without breaking everything else in the library.
    @al-the-x
    al-the-x committed Mar 25, 2014
    Configuration menu
    Copy the full SHA
    ea10697 View commit details
    Browse the repository at this point in the history

  2. Allowing custom signature methods to be registered and used... 

    The "PIZZA" signature method signs all requests with the string "PIZZA" as a trivial example of a custom signing method.
    @al-the-x
    al-the-x committed Mar 25, 2014
    Configuration menu
    Copy the full SHA
    1fa7cf1 View commit details
    Browse the repository at this point in the history