Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please provide tests as a package #35

Merged

Conversation

eriol
Copy link
Contributor

@eriol eriol commented May 5, 2012

Hello,
I'm a member of the Debian Python Module Team and I'm packaging oauthlib for Debian[¹]. The package is
quite ready, you can find it in the team SVN[²]. I only have to enable testing at build time, but right now tests shipped in sdist are not complete: tests/init.py and tests/test_common.py are missing.

Please, can you ship them? As a workaround I will put missing files inside the packaging stuff but only you can fix properly this.

Many thanks in advance!

Kind regards,
Daniele Tricoli

[¹] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=671487
[²] http://anonscm.debian.org/viewvc/python-modules/packages/python-oauthlib/trunk/

test/test_common.py won't be missing. Right now tests shipped in
sdist are broken because of the missing files.
@idan
Copy link
Collaborator

idan commented May 5, 2012

Hi Daniele,

I'll roll a new point release fixing the bugs tonight.

Thanks for pointing it out, and thanks for packaging oauthlib!

I

On Saturday, May 5, 2012 at 3:12, Daniele 'Eriol' Tricoli wrote:

Hello,
I'm a member of the Debian Python Module Team and I'm packaging oauthlib for Debian[¹]. The package is
quite ready, you can find it in the team SVN[²]. I only have to enable testing at build time, but right now tests shipped in sdist are not complete: tests/init.py and tests/test_common.py are missing.

Please, can you ship them? As a workaround I will put missing files inside the packaging stuff but only you can fix properly this.

Many thanks in advance!

Kind regards,
Daniele Tricoli

[¹] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=671487
[²] http://anonscm.debian.org/viewvc/python-modules/packages/python-oauthlib/trunk/

You can merge this Pull Request by running:

git pull https://github.com/eriolv/oauthlib please-provide-tests-as-a-package

Or you can view, comment on it, or merge it online at:

https://github.com/idangazit/oauthlib/pull/35

-- Commit Summary --

  • Provided tests as a package so tests/init.py and

-- File Changes --

M setup.py (2)

-- Patch Links --

https://github.com/idangazit/oauthlib/pull/35.patch
https://github.com/idangazit/oauthlib/pull/35.diff


Reply to this email directly or view it on GitHub:
https://github.com/idangazit/oauthlib/pull/35

@eriol
Copy link
Contributor Author

eriol commented May 22, 2012

Hello Idan,
many thanks for your fast reply and sorry for my late response.

oauthlib 0.1.2 was uploaded to Debian three days ago[¹]. I'm packaging right now python-rsa and then I will update oauthlib.

Thanks for taking care of shipping tests in sdist.

Cheers,
Daniele Tricoli

[¹] http://packages.qa.debian.org/p/python-oauthlib/news/20120519T114818Z.html

@ib-lundgren
Copy link
Collaborator

Hey Daniele and sorry for forgetting this pull request =(

Thanks a lot for packaging for debian and let us know if there is anything we can help out with.

Cheers

ib-lundgren added a commit that referenced this pull request Oct 25, 2012
@ib-lundgren ib-lundgren merged commit 5d0b4c5 into oauthlib:master Oct 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants