Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OIDC tests #565

Merged
merged 5 commits into from Sep 20, 2018
Merged

Fix OIDC tests #565

merged 5 commits into from Sep 20, 2018

Conversation

skion
Copy link
Member

@skion skion commented Jul 21, 2018

After merging #525 we noticed a drop in test coverage from 96% to 92%.

This PR attempts to correct that, re-enabling the undiscovered tests by adding two __init__.py files, and fixing a number of import problems.

@skion skion requested a review from wiliamsouza July 21, 2018 14:12
@skion skion added the Bug label Jul 24, 2018
@skion
Copy link
Member Author

skion commented Jul 24, 2018

@wiliamsouza Can you check if this is OK?

@skion skion requested a review from thedrow July 24, 2018 22:02
@JonathanHuot
Copy link
Member

Also, it raises an interesting question that we don't have the actual details of the tests runs by nosetests or Travis. I'm suggesting to add -v (verbose) to nosetests to trace records of each unittest runs into the Travis console.

I have also tested to produce an html report with nose-htmloutput and it's clear that each tests/openid tests are correctly run in this branch.

Do you see guys, an interest of adding the html report automatically when running tox ?

Copy link
Collaborator

@thedrow thedrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Can we resolve the conflicts please?

@skion
Copy link
Member Author

skion commented Sep 20, 2018

@thedrow Rebased

@thedrow thedrow merged commit 326456c into master Sep 20, 2018
@thedrow thedrow deleted the fix-oidc-tests branch September 20, 2018 22:10
@JonathanHuot
Copy link
Member

Wonderful achievement here, congrats to @wiliamsouza and @skion to make this a reality !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants