Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unittest.mock instead of external mock #720

Merged
merged 1 commit into from Mar 16, 2020
Merged

Use unittest.mock instead of external mock #720

merged 1 commit into from Mar 16, 2020

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Mar 16, 2020

Replace the use of external 'mock' package with built-in Python
unittest.mock (present since py3.3). This also fixes all test failures
for me.

@mgorny
Use unittest.mock instead of external mock
394c019 
Replace the use of external 'mock' package with built-in Python
unittest.mock (present since py3.3).  This also fixes all test failures
for me.
JonathanHuot
JonathanHuot approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@JonathanHuot JonathanHuot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for the PR

@JonathanHuot JonathanHuot added this to the 3.1.1 milestone Mar 16, 2020
@JonathanHuot JonathanHuot merged commit d4716eb into oauthlib:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanHuot JonathanHuot JonathanHuot approved these changes

Assignees
No one assigned
Labels
Cleanup
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mgorny @JonathanHuot