Remove python 3.5 support; add python 3.8 support #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
com4
force-pushed
the
remove_py35_support_add_py38
branch
from
c551fdd
to
3f3f3c5
Compare
|
It looks like the readthedocs build images support python 3.5, 3.6, 3.7, and 3.8 now. I can bump those versions to 3.8 as a part of this pull request if wanted. https://github.com/readthedocs/readthedocs-docker-images#read-the-docs---docker-images |
com4
force-pushed
the
remove_py35_support_add_py38
branch
4 times, most recently
from
3d5283b
to
b8223cc
Compare
auvipy
requested changes
Feb 9, 2021
There was a problem hiding this comment.
can you check this failing build of pypy3 https://travis-ci.org/github/oauthlib/oauthlib/jobs/758172309 ?
- Python 3.5 has reached end-of-life. - Add support for Python 3.8 - Move dist to bionic (xenial is EOL in April) - Upgrade pip in travis.yml's `before_install`. this should install a wheel for pyca/cryptography - Install rust for pypy builds. It is a requirement for cryptography as no pypy wheels exist.
com4
force-pushed
the
remove_py35_support_add_py38
branch
from
b8223cc
to
7697a8e
Compare
auvipy
approved these changes
Feb 10, 2021
|
thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before_install. this should install a wheelfor pyca/cryptography
pypy wheels exist.