Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue759/check authz type #760

Merged
merged 4 commits into from
May 29, 2021

Conversation

n2ygk
Copy link
Contributor

@n2ygk n2ygk commented May 26, 2021

Fixes: #759

Fixes the case where an Authorization header that is not a Bearer is misinterpreted as a Bearer -- and misaligned as well, if, for instance, the header is a Basic.

Copy link
Member

@JonathanHuot JonathanHuot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, i have added a couple of simplification comments; great job still

oauthlib/openid/connect/core/tokens.py Outdated Show resolved Hide resolved
oauthlib/openid/connect/core/tokens.py Outdated Show resolved Hide resolved
@n2ygk n2ygk force-pushed the issue759/check_authz_type branch from 0459589 to 5c78975 Compare May 29, 2021 14:07
@n2ygk n2ygk requested a review from JonathanHuot May 29, 2021 14:08
Copy link
Member

@JonathanHuot JonathanHuot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonathanHuot JonathanHuot merged commit e634ab9 into oauthlib:master May 29, 2021
@JonathanHuot JonathanHuot added Bug OAuth2-Provider This impact the provider part of OAuth2 OIDC OpenID Connect labels May 29, 2021
@JonathanHuot JonathanHuot added this to the 3.1.1 milestone May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug OAuth2-Provider This impact the provider part of OAuth2 OIDC OpenID Connect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OIDC misinterprets "Authorization: Basic" as Bearer
2 participants