v4.7.0 broke code generation

[cvereterra]

Hi guys,

Mea culpa, my PR broke code generation, the tests didn't catch this.

@Xiphe I suggest rolling back to v4.6.0. In the meantime, I will try to fix this and add a PR with a test.

Given this endpoint definition

"paths": {
    "/healthcheck": {
      "get": {
        "responses": {
          "200": {
            "description": "OK",
            "content": {
              "application/json": {
                "schema": {
                  "properties": {
                    "message": {
                      "type": "string",
                      "example": "I'm health"
                    }
                  },
                  "required": ["message"]
                }
              }
            }
          }
        }
      }
    },
 ...
}

The response's schema should be:

{
    message: string;
}

Before v4.7.0, oazapfts generated

export function getHealthcheck(opts?: Oazapfts.RequestOpts) {
    return oazapfts.fetchJson<{
        status: 200;
        data: {
            message: string;
        };
    }>("/healthcheck", {
        ...opts
    });
}

Whereas now, it doesn't type the response

export function getHealthcheck(opts?: Oazapfts.RequestOpts) {
    return oazapfts.fetchJson<{
        status: 200;
        data: {};
    }>("/healthcheck", {
        ...opts
    });
}

[cvereterra]

Narrowed it down to the filtering done here in generate.ts (line 741). onlyMode is passed as readOnly since it's the result of a GET. The response schema is not flagged as readOnly by isSchemaReadOnly, so it get's filtered out.

 /**
   * Recursively creates a type literal with the given props.
   */
  getTypeFromProperties(
    props: {
      [prop: string]: SchemaObject | OpenAPIV3.ReferenceObject;
    },
    required?: string[],
    additionalProperties?:
      | boolean
      | OpenAPIV3.SchemaObject
      | OpenAPIV3.ReferenceObject,
    onlyMode?: OnlyMode
  ): ts.TypeLiteralNode {
    const members: ts.TypeElement[] = Object.keys(props)
      .filter((name) => {
        const schema = props[name];
        if (!onlyMode)
          return (
            !this.isSchemaReadOnly(schema) && !this.isSchemaWriteOnly(schema)
          );
        if (onlyMode === "readOnly") return this.isSchemaReadOnly(schema);
        else if (onlyMode === "writeOnly")
          return this.isSchemaWriteOnly(schema);
      })
      .map((name) => {
        const schema = props[name];
        const isRequired = required && required.includes(name);
        let type = this.getTypeFromSchema(schema, name);
        if (!isRequired && this.opts.unionUndefined) {
          type = factory.createUnionTypeNode([type, cg.keywordType.undefined]);
        }
        return cg.createPropertySignature({
          questionToken: !isRequired,
          name,
          type,
        });
      });

[github-actions]

🎉 This issue has been resolved in version 4.7.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀