Account for properties and additionalProperties in allOf #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, should've checked before I opened this - but it's a duplicate of #120 |
|
Just noting for anyone else that might be following this on RTKQ's behalf - we're going to start maintaining a patched version of this for issues that impact our users directly. |
jonkoops
requested changes
Jun 9, 2022
.prettierrc
Outdated
| @@ -0,0 +1,4 @@ | |||
| { | |||
There was a problem hiding this comment.
Could we remove the Prettier config from this PR? Seems out of scope for the changes here.
msutkowski
force-pushed
the
handle-additional-properties-in-intersection
branch
from
b3ef644
to
e4ff774
Compare
msutkowski
force-pushed
the
handle-additional-properties-in-intersection
branch
from
e4ff774
to
765112a
Compare
|
oh, were the changes here also part of #234 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! We've had a handful of issues reporting inaccurate type generation for users of RTK Query Code Generator which leverages oazapfts.
I made a quick reproduction comparing oazapfts output to a user-provided schema to various other generators here: https://github.com/msutkowski/oazapfts-typesecript-codegen-repro. You can see that other generators will produce a type like:
type Dog = Animal & { uniqueDogProp?: string | null }.With the current version of oazapfts, we were generating
type Dog = AnimalThis PR addresses that by accounting for
propertiesandadditionalPropertieswhen handling theschema.allOfcase. The diff in the output looks like this against the repro above:Referenced issues with reports: