Skip to content
This repository has been archived by the owner on Mar 6, 2022. It is now read-only.

Database Pages Direction Only Changes After Opening a Nested Page #25

Open
obahareth opened this issue Sep 26, 2021 · 5 comments
Open
Assignees
Labels
bug Something isn't working Hacktoberfest Hacktoberfest 2021 help wanted Extra attention is needed

Comments

@obahareth
Copy link
Owner

obahareth commented Sep 26, 2021

Database pages are not turned to RTL by default, you have to open a subpage first for it to work.

See the example here:
2021-09-26 15 53 46

@obahareth obahareth added the bug Something isn't working label Sep 26, 2021
@obahareth
Copy link
Owner Author

@Fahme Could you check this out? It might be related to the mutation observer.

@obahareth obahareth added help wanted Extra attention is needed Hacktoberfest Hacktoberfest 2021 labels Sep 26, 2021
@obahareth obahareth changed the title Database Pages Direction Only Changes After Opening a Nested Page test Oct 9, 2021
@obahareth obahareth changed the title test Database Pages Direction Only Changes After Opening a Nested Page Oct 9, 2021
@dragonwocky
Copy link
Contributor

@Fahme
Copy link
Collaborator

Fahme commented Oct 22, 2021

p.s. this is fixed in https://github.com/notion-enhancer/repo/blob/dev/right-to-left/client.mjs

Thanks for pointing out to your repo, if you feel you can make a PR to fix this issue we appreciate it as our user base are using this version of the extension right now.

@dragonwocky
Copy link
Contributor

dragonwocky commented Oct 23, 2021

@Fahme I can create a PR if you want, but it would nearly be a complete rewrite vs. what's currently in this repo - what I've made depends on some different code patterns and helpers that are used throughout the notion-enhancer for performant/accurate modding.

In a month or so the notion-enhancer extension will go up on the chrome store so RTL can be used through there (I've chatted with @obahareth about this and he's happy with it).

@dragonwocky
Copy link
Contributor

FYI the notion-enhancer is now available on the Firefox Add-on store and the Chrome Webstore: https://notion-enhancer.github.io/getting-started/installation

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Hacktoberfest Hacktoberfest 2021 help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants