ci(reporting): Fix Incorrect Test Coverage Report (#58)

Since switching to the parallel build test coverage is not reported correctly. It's still enforced at 100% but the reported values to codeclimate are 17%
obartra · Nov 29, 2016 · 64cebb3 · 64cebb3
1 parent f11abea
commit 64cebb3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/ci/node0.sh b/ci/node0.sh
@@ -2,12 +2,7 @@
 #
 # Runs testing tasks on first CircleCI node
 #
-# Coverage related tasks are grouped together because they all depend on the output of
-# `npm run cover`.
 
 echo "Running node $CIRCLE_NODE_INDEX"
 
 npm run cover                         # Report test coverage locally
-npm run cover:check                   # Fail if coverage drops below 100%
-npm run codeclimate                   # Run tests and send coverage to code climate
-cp -R coverage/* $CIRCLE_TEST_REPORTS # Copy test coverage reports for CircleCI
diff --git a/circle.yml b/circle.yml
@@ -21,6 +21,9 @@ test:
   override:
     - ci/node$CIRCLE_NODE_INDEX.sh:
         parallel: true
+    - npm run cover:check                   # Fail if coverage drops below 100%
+    - npm run codeclimate                   # Run tests and send coverage to code climate
+    - cp -R coverage/* $CIRCLE_TEST_REPORTS # Copy test coverage reports for CircleCI
     - |
       # `canvas` package needs a different install depending on the node version in use.
       nvm use $NODE_012 && rm -rf node_modules/canvas && npm i