Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_cert function to Rustica agent #51

Merged
merged 4 commits into from
May 9, 2024

Conversation

timweri
Copy link
Collaborator

@timweri timweri commented May 8, 2024

  • FFI was manually tested. It works.
  • SSH Agent get cert still works.

@timweri timweri changed the title Add get_cert function to Rustica agent [WIP] Add get_cert function to Rustica agent May 8, 2024
@@ -26,7 +26,7 @@ serde = "1.0.97"
serde_derive = "1.0"
sha2 = "0.9.2"
# For Production
sshcerts = "0.13.1"
sshcerts = { version = "0.13.1", git = "https://github.com/obelisk/sshcerts", branch = "add-cert-trait" }
Copy link
Collaborator Author

@timweri timweri May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO(timweri): Merge this branch in sshcerts and remove the git pinning

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@obelisk Can you merge this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timweri timweri changed the title [WIP] Add get_cert function to Rustica agent Add get_cert function to Rustica agent May 8, 2024
@timweri timweri requested a review from obelisk May 8, 2024 23:05
@obelisk obelisk merged commit ac7199d into hacking_on_mozilla May 9, 2024
@timweri timweri deleted the add-rustica-agent-get-cert branch May 9, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants