Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarding intra cellular electrophysiology recording assay hierarchy #1458

Closed
patrick-lloyd-ray opened this issue Nov 16, 2021 · 5 comments
Assignees

Comments

@patrick-lloyd-ray
Copy link

Looking at the classes under ‘intra cellular electrophysiology recording assay’ there are three classes: current clamp assay, patch clamp assay, and voltage clamp assay. I think that both current clamp assay and voltage clamp assay are types of patch clamp assay (they are the two ways that one can perform a patch clamp assay).

image

Perhaps there is a good reason for these three to be under ‘intra cellular electrophysiology recording assay’ – e.g., having only one child class under a parent is a “bad smell” for some ontologists. However, this could lead some users think that these classes are disjoint when they are not. Thoughts?

@rvita
Copy link

rvita commented Nov 16, 2021 via email

@rvita
Copy link

rvita commented Nov 22, 2021

I am sorry to say that Brenda Farrell is no longer working, so she will be unable to comment. These assays are not within my area of expertise, so I can offer no other input.

@nsuvarnaiari
Copy link
Contributor

Hi All,

We have noticed that there is already a term - "electrophysiology assay" (OBI:0002176). But, extracellular electrophysiology recording assay (OBI:0000454) and intra cellular electrophysiology recording assay (OBI:0000447) are not the children of "electrophysiology assay". I think it makes more sense to add those relationships.

Thanks,
Suvvi and @mgiglio99

@hectorguzor
Copy link
Contributor

Discussed on OBI call 2021-11-22: There were no comments on the hierarchy of ‘intra cellular electrophysiology recording assay’. There was agreement that 'extracellular electrophysiology recording assay' (OBI:0000454) and 'intra cellular electrophysiology recording assay' (OBI:0000447) should be made children of 'electrophysiology assay' (OBI:0002176).

@hectorguzor
Copy link
Contributor

PR #1499 was merged. @hectorguzor discussed with @patrick-lloyd-ray that for now we will leave the intra cellular electrophysiology recording assay hierarchy as is. If changes need to be made in the future, we can reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants