Run cargo build and test built binary to ensure it works #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
reviewed
Dec 23, 2022
There was a problem hiding this comment.
imo if you have this complex of a step, it should probably broken out.
What I'd recommend doing is writing this as a test. Cargo builds binaries before running tests, so you can write end-to-end cli tests in Rust. I used to write mine with assert_cmd/assert_fs but have switched to snapbox
|
Thanks for the information! I wrote the test using |
epage
reviewed
Dec 23, 2022
epage
reviewed
Dec 23, 2022
obi1kenobi
reviewed
Dec 26, 2022
obi1kenobi
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #235