Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump monaco-graphql, update editor configs #231

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

paavanb
Copy link
Collaborator

@paavanb paavanb commented Apr 1, 2023

  • Bumps the monaco-graphql library
  • Updates config to disableSuggestionOnEnter, so hitting Enter always creates a new line rather than selecting the current autocomplete option
  • Updates config to disable suggestOnTriggerCharacters. Big deal! No longer will hitting space automatically bring up autocomplete, which has been very frustrating for users. Entering characters will still bring up the autocomplete, as well as ctrl-space.

@paavanb paavanb requested a review from obi1kenobi April 1, 2023 17:04
@obi1kenobi
Copy link
Owner

Amazing! This will be a huge quality of life upgrade for the editor. Thanks for finding these options and making the PR! ❤️

@obi1kenobi obi1kenobi merged commit eb2fbaf into main Apr 3, 2023
@obi1kenobi obi1kenobi deleted the feat-bump-editor-pkgs branch April 3, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants