Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor materializeWebsite in browser_based_querying #300

Merged
merged 2 commits into from
Jun 3, 2023
Merged

Refactor materializeWebsite in browser_based_querying #300

merged 2 commits into from
Jun 3, 2023

Conversation

u9g
Copy link
Contributor

@u9g u9g commented Jun 3, 2023 •
edited

This makes it much simpler to add new materializers based on urls, and simplifies the existing logic.

The various other changes are from prettier linting

obi1kenobi
obi1kenobi reviewed Jun 3, 2023
View reviewed changes
Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this code up! Just a couple of minor questions largely because I'm not that familiar with TypeScript.

experiments/browser_based_querying/src/hackernews/adapter.ts Outdated Show resolved Hide resolved
experiments/browser_based_querying/src/hackernews/adapter.ts Show resolved Hide resolved
@obi1kenobi obi1kenobi merged commit a085c0d into obi1kenobi:main Jun 3, 2023
16 checks passed
@u9g u9g deleted the patch-1 branch June 3, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obi1kenobi obi1kenobi obi1kenobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@u9g @obi1kenobi