Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add InvalidSchemaError::DuplicateFieldDefinition #373

Merged
merged 4 commits into from
Jul 12, 2023
Merged

add InvalidSchemaError::DuplicateFieldDefinition #373

merged 4 commits into from
Jul 12, 2023

Conversation

u9g
Copy link
Contributor

@u9g u9g commented Jul 12, 2023

closes #356

@u9g u9g changed the title add DuplicateFieldDefinition add InvalidSchemaError::DuplicateFieldDefinition Jul 12, 2023
@obi1kenobi
Copy link
Owner

Very nice!

Can you add a test case for this? You can add a new test schema file in trustfall_core/test_data/tests/schema_errors/ that triggers this error, then run scripts/create_schema_error_data.sh <schema_file> and make sure the newly generated schema error output is correct.

@obi1kenobi obi1kenobi added A-errors Area: external-facing error functionality C-enhancement Category: raise the bar on expectations labels Jul 12, 2023
@u9g
Copy link
Contributor Author

u9g commented Jul 12, 2023

Very nice!

Can you add a test case for this? You can add a new test schema file in trustfall_core/test_data/tests/schema_errors/ that triggers this error, then run scripts/create_schema_error_data.sh <schema_file> and make sure the newly generated schema error output is correct.

Done!

@obi1kenobi obi1kenobi merged commit 8cee04e into obi1kenobi:main Jul 12, 2023
17 checks passed
@u9g u9g deleted the implement-DuplicateFieldDefinition branch July 12, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obi1kenobi obi1kenobi obi1kenobi approved these changes

Assignees
No one assigned
Labels
A-errors Area: external-facing error functionality C-enhancement Category: raise the bar on expectations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema::new unwrapping None
2 participants
@u9g @obi1kenobi