Check that adapters implement declared properties, edges, and coercions. #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obi1kenobi
force-pushed
the
adapter_correctness
branch
from
eb82e3f
to
1506785
Compare
Also fix a ton of the issue the invariant checker found 😅
obi1kenobi
commented
Jul 19, 2023
There was a problem hiding this comment.
All changes in this file are to resolve existing bugs that the invariant checker found in this adapter, such as failures to adhere to its own schema etc.
obi1kenobi
commented
Jul 20, 2023
There was a problem hiding this comment.
Changes in this file also resolve existing bugs in this adapter implementation that the new checker found.
obi1kenobi
commented
Jul 20, 2023
Comment on lines
+40
to
+46
| name: String | ||
| value: Int | ||
| vowelsInName: [String] | ||
|
|
||
| predecessor: Number | ||
| successor: Number! | ||
| multiple(max: Int!): [Composite!] | ||
| predecessor: Number | ||
| successor: Number! | ||
| multiple(max: Int!): [Composite!] |
There was a problem hiding this comment.
Formatting change to match the rest of the schema file.
obi1kenobi
added
A-interpreter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.