Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add schema starting edge to schemaadapter #413

Merged
merged 12 commits into from
Aug 1, 2023
Merged

add schema starting edge to schemaadapter #413

merged 12 commits into from
Aug 1, 2023

Conversation

u9g
Copy link
Contributor

@u9g u9g commented Jul 28, 2023

No description provided.

u9g
u9g commented Jul 28, 2023
View reviewed changes
Copy link
Contributor Author

@u9g u9g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some thoughts

trustfall_core/src/schema/adapter/schema.graphql Show resolved Hide resolved
trustfall_core/src/schema/adapter/tests.rs Outdated Show resolved Hide resolved
trustfall_core/src/schema/adapter/mod.rs Outdated Show resolved Hide resolved
trustfall_core/src/schema/adapter/mod.rs Outdated Show resolved Hide resolved
obi1kenobi
obi1kenobi reviewed Jul 28, 2023
View reviewed changes
trustfall_core/src/schema/adapter/mod.rs Outdated Show resolved Hide resolved
trustfall_core/src/schema/adapter/mod.rs Outdated Show resolved Hide resolved
trustfall_core/src/schema/adapter/mod.rs Outdated Show resolved Hide resolved
trustfall_core/src/schema/adapter/mod.rs Outdated Show resolved Hide resolved
trustfall_core/src/schema/adapter/mod.rs Outdated Show resolved Hide resolved
trustfall_core/src/schema/adapter/mod.rs Outdated Show resolved Hide resolved
trustfall_core/src/schema/adapter/mod.rs Outdated Show resolved Hide resolved
trustfall_core/src/schema/adapter/schema.graphql Show resolved Hide resolved
obi1kenobi
obi1kenobi reviewed Jul 31, 2023
View reviewed changes
Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two tiny nitpicks.

trustfall_core/src/schema/adapter/schema.graphql Show resolved Hide resolved
trustfall_core/src/schema/adapter/tests.rs Outdated Show resolved Hide resolved
u9g and others added 2 commits August 1, 2023 11:02
obi1kenobi
obi1kenobi approved these changes Aug 1, 2023
View reviewed changes
Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, ship it 🚀

@obi1kenobi obi1kenobi merged commit 1ce4f78 into obi1kenobi:main Aug 1, 2023
18 checks passed
@u9g u9g deleted the schema-adapter-schema-edge branch August 1, 2023 16:46
@obi1kenobi obi1kenobi added A-schema Area: the data model that queries use R-relnotes Release: document this in the release notes of the next release labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obi1kenobi obi1kenobi obi1kenobi approved these changes

Assignees
No one assigned
Labels
A-schema Area: the data model that queries use R-relnotes Release: document this in the release notes of the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@u9g @obi1kenobi