Allow any script to be executed anywhere inside the repo #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obi1kenobi
reviewed
Aug 14, 2023
| for INPUT_FILE in "$@"; do | ||
| # makes sure we are always using absolute path | ||
| INPUT_FILES+=("$(cd "$(dirname "$1")"; pwd)/$(basename "$1")") |
There was a problem hiding this comment.
This is a nice trick, I'll have to remember that! 💯
obi1kenobi
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed most tests were doing
cd "$(git rev-parse --show-toplevel)/trustfall_testbin", except those that receive paths as parameters. My guess is those scripts were not doing that because the user may give relative paths and changing the directory will break user assumptions about it.For those scripts, I transform any path the user set as arguments into an absolute path, so we can safely move directories.
I tested this by passing absolute paths and relative paths on Linux.