New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an iterator over all the required properties of a Vertex #449

Merged

obi1kenobi merged 22 commits into obi1kenobi:main from era:era/newop

Aug 21, 2023

Contributor

era commented Aug 14, 2023

In order to enable adapters to only fetch the required properties (useful for network calls, such as GraphQL adapters) we need to expose all the required properties of that vertex.

This PR introduces a method to retrieve the information (output, filtered, and tagged properties). It also introduces a new struct to represent those properties.

It also introduces tests for the new feature.


          adding a vec of the vertex properties

cad6864

era commented

View reviewed changes

trustfall_core/src/interpreter/hints/vertex_info.rs Show resolved Hide resolved

era commented

View reviewed changes

trustfall_core/src/interpreter/hints/vertex_info.rs Show resolved Hide resolved

era commented

View reviewed changes

trustfall_core/src/interpreter/hints/vertex_info.rs Outdated Show resolved Hide resolved

era commented

View reviewed changes

trustfall_core/src/interpreter/hints/vertex_info.rs Outdated Show resolved Hide resolved

era commented

View reviewed changes

trustfall_core/src/interpreter/hints/vertex_info.rs Show resolved Hide resolved

era added 2 commits

August 14, 2023 15:39


          test files

979b75e


          rust fmt

1193a0d

obi1kenobi reviewed

View reviewed changes

Owner

obi1kenobi left a comment

This is headed in a good direction, well done!

trustfall_core/src/interpreter/hints/vertex_info.rs Outdated Show resolved Hide resolved

trustfall_core/src/interpreter/hints/vertex_info.rs Show resolved Hide resolved

trustfall_core/src/interpreter/hints/vertex_info.rs Outdated Show resolved Hide resolved

trustfall_core/test_data/tests/valid_queries/required_properties.graphql.ron Outdated Show resolved Hide resolved

trustfall_core/src/interpreter/hints/tests/mod.rs Outdated Show resolved Hide resolved

era and others added 2 commits

August 15, 2023 08:09


          Update trustfall_core/test_data/tests/valid_queries/required_properti…

d70fdf6

…es.graphql.ron

Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>


          Update trustfall_core/src/interpreter/hints/vertex_info.rs

24a2099

Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>

era commented

View reviewed changes

trustfall_core/src/interpreter/hints/tests/mod.rs Outdated Show resolved Hide resolved

obi1kenobi reviewed

View reviewed changes

trustfall_core/src/interpreter/hints/vertex_info.rs Outdated Show resolved Hide resolved

trustfall_core/src/interpreter/hints/vertex_info.rs Show resolved Hide resolved

trustfall_core/src/interpreter/hints/vertex_info.rs Outdated Show resolved Hide resolved

trustfall_core/src/interpreter/hints/tests/mod.rs Outdated Show resolved Hide resolved

era added 4 commits

August 17, 2023 10:20


          returning iterator instead of vec

99d0ecd


          remove edges from the iterator

8f5bf4b


          simplify closure

09577d4


          flat_map instead of pure map followed by flatten

736ef85

era commented

View reviewed changes

trustfall_core/src/interpreter/hints/vertex_info.rs Outdated Show resolved Hide resolved


          removing commented code

55502e2

era commented

View reviewed changes

trustfall_core/src/interpreter/hints/tests/mod.rs Show resolved Hide resolved


          use HashSet internally instead of vec

8769c97

obi1kenobi reviewed

View reviewed changes

trustfall_core/src/interpreter/hints/vertex_info.rs Outdated Show resolved Hide resolved

trustfall_core/src/interpreter/hints/vertex_info.rs Outdated Show resolved Hide resolved

trustfall_core/src/interpreter/hints/vertex_info.rs Outdated Show resolved Hide resolved

era added 2 commits

August 17, 2023 22:04


          uses filter_map

82fedb9


          chain iterators

be089f0

era commented

View reviewed changes

trustfall_core/src/interpreter/hints/vertex_info.rs Outdated Show resolved Hide resolved

obi1kenobi reviewed

View reviewed changes

Owner

obi1kenobi left a comment

Doing great! 🎉 I think just docs and tests left at this point.

trustfall_core/src/interpreter/hints/tests/mod.rs Outdated Show resolved Hide resolved

era added 4 commits

August 18, 2023 09:22


          documentation

42140fb


          using vec instead of hashset for test

2e47fde


          one more test covering duplicated properties and fold with transform

afc7d68


          more docs

68b1845

obi1kenobi reviewed

View reviewed changes

trustfall_core/src/interpreter/hints/vertex_info.rs Outdated Show resolved Hide resolved

obi1kenobi reviewed

View reviewed changes

trustfall_core/test_data/tests/valid_queries/required_properties_list_fold.graphql.ron Outdated Show resolved Hide resolved

era added 3 commits

August 18, 2023 14:57


          fix ilegal test

e224fad


          fix wording

a0cd46b


          exporting new struct

1e0779d

era changed the title ~~[WIP] Add an iterator over all the required properties of a Vertex~~ Add an iterator over all the required properties of a Vertex

era marked this pull request as ready for review

August 18, 2023 14:59

obi1kenobi reviewed

View reviewed changes

trustfall_core/src/interpreter/hints/vertex_info.rs Outdated Show resolved Hide resolved


          Update trustfall_core/src/interpreter/hints/vertex_info.rs

0064ac8

obi1kenobi approved these changes

View reviewed changes

Owner

obi1kenobi left a comment

Nicely done!


          Merge branch 'main' into era/newop

14c7a4f

obi1kenobi enabled auto-merge (squash)

August 21, 2023 00:12

obi1kenobi merged commit f1b81aa into obi1kenobi:main

11 checks passed

obi1kenobi added A-adapter L-rust R-relnotes labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment