Skip to content

Commit

Permalink
Don't use authorize_url as this incurs a ~15s request penalty when ac…
Browse files Browse the repository at this point in the history
…cessing Etsy.
  • Loading branch information
obitum committed Mar 4, 2014
1 parent 007cd6a commit 2491d56
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion lib/omniauth/strategies/etsy.rb
Expand Up @@ -31,9 +31,21 @@ def request_phase
options.request_params.merge!(:scope => options.scope.gsub(',', ' '))
end
prep_sandbox
super

request_token = consumer.get_request_token({:oauth_callback => callback_url}, options.request_params)
session['oauth'] ||= {}
session['oauth'][name.to_s] = {'callback_confirmed' => request_token.callback_confirmed?, 'request_token' => request_token.token, 'request_secret' => request_token.secret}

# Etsy is too slow when you don't provide the oauth_consumer_key
redirect request_token.params[:login_url]

rescue ::Timeout::Error => e
fail!(:timeout, e)
rescue ::Net::HTTPFatalError, ::OpenSSL::SSL::SSLError => e
fail!(:service_unavailable, e)
end


def callback_phase
prep_sandbox
super
Expand Down

0 comments on commit 2491d56

Please sign in to comment.