Fixed wrong statement about thread safety of formatters #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed wrong statement about thread safety of NSDateFormatter and NSNumberFormatter
|
Hm, great point. But I think it's slightly more complicated even. Even if the properties themselves have atomic getters and setters, the fact that the object is mutable at all makes it unsafe for multi-threaded programming... I'm not sure what's the best way to word this. |
|
I just cited Apple docs in footnote. May be it does make sense add a ref to Apple docs in footnote as well. |
|
If Apple states these are thread safe in iOS 7+, I believe them. It's interesting how they achieved that. Lock free structures? Good question to ask in labs in WWDC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed wrong statement about thread safety of NSDateFormatter and NSNumberFormatter