BUNDLING_PLACEHOLDER not removed in bundles #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem ------- The BUNDLING_PLACEHOLDER was only removed for the first bundle in a group. Solution -------- Save addresses for bundle to temporary set, erase BUNDLING_PLACEHOLDER, and use temporary.
simpsont-oci
approved these changes
Oct 15, 2020
simpsont-oci
pushed a commit
that referenced
this pull request
Nov 1, 2020
BUNDLING_PLACEHOLDER not removed in bundles (cherry picked from commit 07cb8da)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The BUNDLING_PLACEHOLDER was only removed for the first bundle in a
group.
Solution
Save addresses for bundle to temporary set, erase
BUNDLING_PLACEHOLDER, and use temporary.