Liveliness Qos Updates - Fix failing test observed in some cases. #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t instead of trying to track all variables in the liveliness update. This is due to two possible states after receiving the SYSTEM_SHUTDOWN message. Not alive count could go to 1 or straight to 0 based on how the writer shuts down but does not alter the actual test pass/fail requirements. (In a test-passing scenario the AlertDataReaderListenerImpl could receive either 2 or 3 liveliness updates depending on timing).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update requirements for expected values. Base pass/fail on alive_count instead of trying to track all variables in the liveliness update. This is due to two possible states after receiving the SYSTEM_SHUTDOWN message. Not alive count could go to 1 or straight to 0 based on how the writer shuts down but does not alter the actual test pass/fail requirements. (In a test-passing scenario the AlertDataReaderListenerImpl could receive either 2 or 3 liveliness updates depending on timing).