Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict review period state transitions #2218

Closed
2 tasks
mkimberlin opened this issue Apr 24, 2024 · 3 comments · Fixed by #2426
Closed
2 tasks

Restrict review period state transitions #2218

mkimberlin opened this issue Apr 24, 2024 · 3 comments · Fixed by #2426
Assignees
@timyates @ZacharyKlein
Labels
enhancement New feature or request server

Comments

@mkimberlin
Copy link
Member

Depends on #2217.

As an Administrator, I want the API for managing review periods to enforce the allowed progressions between review period states (Planning -> Awaiting Approval -> Open -> Closed) so that I can't accidentally transition a review period to an invalid state.

Acceptance Criteria

  • The API endpoints for updating the status field of a ReviewPeriod should restrict updates to only allowed transitions based on the current state.
  • Progression between states can only move forward, except Closed which can be re-opened.
@mvolkmann
Copy link
Collaborator

@mkimberlin In the current UI, how does the user cause a review period to transition to a new state?

@mkimberlin
Copy link
Member Author

mkimberlin commented May 6, 2024 •
edited

@mkimberlin In the current UI, how does the user cause a review period to transition to a new state?

@mvolkmann There isn't such a concept in the current UI. There is only Open or Closed (Archived).

@mkimberlin mkimberlin added enhancement New feature or request server labels May 20, 2024
@ZacharyKlein ZacharyKlein self-assigned this May 21, 2024
@ZacharyKlein
Copy link
Collaborator

@timyates This might be a good story for you to pick up next. I think we need to implement a simple state machine based on the previous work in #2217

@timyates timyates self-assigned this May 22, 2024
@timyates timyates linked a pull request May 22, 2024 that will close this issue
Restrict review period status transitions #2426
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timyates timyates

@ZacharyKlein ZacharyKlein

Labels
enhancement New feature or request server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restrict review period status transitions objectcomputing/check-ins
4 participants
@timyates @mvolkmann @mkimberlin @ZacharyKlein