Restrict review period status transitions #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to updating a ReviewPeriod, we now validate that the ReviewStatus follows the following rules: - State can remain the same - `PLANNING` can progress to `AWAITING_APROVAL` - `AWAITING_APPROVAL` can progress to `OPEN` - `OPEN` can progress to `CLOSED` - `CLOSED` can progress to `OPEN` (for when a case is re-opened) - `UNKNOWN` can progress to `PLANNING` (`UNKNOWN` was used for period where isOpen was NULL prior to migration) All other state changes will cause a `BAD_REQUEST` response with an appropriate message
2 tasks
ZacharyKlein
approved these changes
May 22, 2024
There was a problem hiding this comment.
LGTM, tagging @mkimberlin to validate that the state transitions are all correct.
mjperry91
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to updating a ReviewPeriod, we now validate that the ReviewStatus follows the following rules:
PLANNINGcan progress toAWAITING_APROVALAWAITING_APPROVALcan progress toOPENOPENcan progress toCLOSEDCLOSEDcan progress toOPEN(for when a case is re-opened)UNKNOWNcan progress toPLANNING(UNKNOWNwas used for period where isOpen was NULL prior to migration)All other state changes will cause a
BAD_REQUESTresponse with an appropriate message