Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 934/implementing cypress in the development environment #1188

Draft
wants to merge 74 commits into
base: develop
Choose a base branch
from
Draft

Feature 934/implementing cypress in the development environment #1188

wants to merge 74 commits into from

Conversation

pieperm
Copy link
Collaborator

@pieperm pieperm commented Jul 12, 2021 •
edited by moshirim
Loading

In this PR, Cypress was implemented and configured in the Check-ins application. It now runs as part of the Gradle build.

If you'd like to see the Cypress tests run: use the command npx Cypress run. (Note: The test that runs is a dummy test - only to check the functionality of Cypress in the app and the Github workflow.)

@pieperm pieperm added the spike label Jul 12, 2021
@pieperm pieperm added this to the Feedback milestone Jul 12, 2021
@pieperm pieperm self-assigned this Jul 12, 2021
@pieperm pieperm linked an issue Jul 12, 2021 that may be closed by this pull request
Implementing Cypress in the development environment. #934
Open
@pieperm pieperm temporarily deployed to Test July 22, 2021 20:07 Inactive
@moshirim moshirim changed the base branch from feedback to develop October 29, 2021 15:05
mkimberlin
mkimberlin reviewed Nov 2, 2021
View reviewed changes
server/build.gradle Outdated Show resolved Hide resolved
@moshirim moshirim requested review from Bagurp, moshirim and mkimberlin and removed request for moshirim November 2, 2021 20:18
@Bagurp
Copy link
Contributor

Bagurp commented Nov 2, 2021

Any chance we could squash some of the commits in this PR before merging it?

@mkimberlin
Copy link
Member

The login test does not complete. It shows as "pending" in the log:
https://github.com/oci-labs/check-ins/runs/4084677350?check_suite_focus=true

@moshirim
Copy link
Contributor

moshirim commented Nov 3, 2021

The login test does not complete. It shows as "pending" in the log: https://github.com/oci-labs/check-ins/runs/4084677350?check_suite_focus=true

Yes that was intentional. I used it.skip so that it does not run. That test passes successfully in local but fails on remote because we are unable to access localhost 8080. I was planning on discussing that with you and how we can get around that problem when writing Cypress tests. I have created an issue for that as well. @mkimberlin

@moshirim
Copy link
Contributor

moshirim commented Nov 3, 2021

Any chance we could squash some of the commits in this PR before merging it?

Addressing that now.

@mkimberlin
Copy link
Member

I think instead of localhost, you want to point it at the docker host. Try host.docker.internal

@mkimberlin
Copy link
Member

If that doesn't work, then try 172.17.0.1

@mkimberlin mkimberlin marked this pull request as draft November 19, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moshirim moshirim moshirim left review comments

@jahanner jahanner Awaiting requested review from jahanner

@devaughns devaughns Awaiting requested review from devaughns

@Bagurp Bagurp Awaiting requested review from Bagurp

@mkimberlin mkimberlin Awaiting requested review from mkimberlin

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.

Implementing Cypress in the development environment.
4 participants
@pieperm @Bagurp @mkimberlin @moshirim