feature-1884/update-onboardsurvey-complete-table #1946
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S78901
reviewed
Aug 19, 2022
|
|
||
| const postJobHistory = (jobHistoryData, accessToken) => { | ||
| return async (dispatch, getState)=>{ | ||
|
|
There was a problem hiding this comment.
It looks like this is an empty method call.
S78901
reviewed
Aug 19, 2022
|
|
||
| export const updateBackgroundInformation = async (cookie) => { | ||
| return resolve({ | ||
| url:backgroundInformationUrl, |
There was a problem hiding this comment.
If you merge the changes from develop in, I believe you will see that there is now a required field, 'emailAddress' which should also be sent through to the backend to retrieve data. However, it looks like the only available way currently in the background information controller to get info is by Id. This will need to change.
|
Needs some work, per Syd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to retrieve "stepComplete" variable from BackgroundInformation in check-ins table from onboard app.