[2064] Permissions Page init #2067
Conversation
|
@S78901 Is this branch up to date with your most recent changes? I'm trying to level set on where the Swagger config is between |
|
It is up to date.
|
There was a problem hiding this comment.
The more that I have considered this, I don't think that this actually gains us much capability. I know that is going to be hard to hear, but because the roles are hardcoded, we don't have the ability to add a new role without altering this page. The page is tightly coupled to both the roles and the permissions as they currently exist. It results in the need to edit this page for any changes in either.
I really think this page should allow a user to select the role they are working with (options dynamically loaded from a service call), and then present them with a list of permissions with checkboxes (checked if they have the permission, unchecked if they don't). Those permissions would ideally be loaded from a service call as well.
We could merge this as is, but I think it's going to need to be adjusted right away, as this doesn't get to the main need: To be able to define new roles and assign them permissions.
| @@ -96,6 +96,7 @@ const Root = styled('div')(({theme}) => ({ | |||
|
|
|||
| const adminLinks = [ | |||
| // ["/admin/permissions", "Permissions"], | |||
| ["/admin/edit-permissions", "Permissions Roles"], | |||
There was a problem hiding this comment.
Let's just call this menu item "Permissions".
| @@ -101,6 +102,10 @@ export default function Routes() { | |||
| <Header title="Skills" /> | |||
| <EditSkillsPage /> | |||
| </Route> | |||
| <Route path="/admin/edit-permissions"> | |||
| <Header title="Permissions Roles" /> | |||
| }, | ||
| }); | ||
| } else { | ||
| console.log(res?.error); |
There was a problem hiding this comment.
Leftover console.log(). I would remove this.
| }, | ||
| }); | ||
| } else { | ||
| console.log(res?.error); |
There was a problem hiding this comment.
Ditto...Leftover console.log().
| if (csrf) { | ||
| doTask1(); | ||
| doTask2(); | ||
| doTask3(); |
There was a problem hiding this comment.
I would make these more descriptive names.
In reference to:
#2064