Feature 2106/add category to skills #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ategoryCard component
…yCard and the dialog for creating new category
…lls' into feature-2106/add-category-to-skills
…into feature-2106/add-category-to-skills
pieperm
requested review from
mkimberlin,
Samibanley,
S78901 and
ZacharyKlein
and removed request for
ZacharyKlein and
mkimberlin
mkimberlin
previously approved these changes
Mar 21, 2024
mkimberlin
previously approved these changes
Mar 21, 2024
S78901
previously approved these changes
Mar 22, 2024
Samibanley
previously approved these changes
Mar 22, 2024
…into feature-2106/add-category-to-skills # Conflicts: # server/src/main/java/com/objectcomputing/checkins/security/permissions/Permissions.java # web-ui/src/components/routes/Routes.jsx
pieperm
dismissed stale reviews from Samibanley, S78901, and mkimberlin
via
11b68cf
…into feature-2106/add-category-to-skills # Conflicts: # server/src/main/java/com/objectcomputing/checkins/security/permissions/Permissions.java # web-ui/src/components/routes/Routes.jsx
…lls' into feature-2106/add-category-to-skills # Conflicts: # server/src/main/java/com/objectcomputing/checkins/security/permissions/Permissions.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test this, log in as an admin and go to http://localhost:8080/admin/skill-categories. You can also navigate there from the menu by going to ADMIN > Skills and then clicking the "Categorize Skills" button. From there, you should be able to create categories for skills, edit categories, and delete categories. Editing categories allows adding or removing skills in a category.
This also adds a
DataAccessExceptionHandlerwhich handles cases of supplying null IDs in HTTP requests. These cases used to produce an HTTP response of "internal server error", but now will respond with "bad request." (1 test affected;EmployeeHoursControllerTestupdated accordingly)Closes #2106